Refactor/rework objects #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ # ] AdvancedCommunityInfo is now adapted to work with the default JSON serializer [ + ] Added AdvancedCommunitySettings [ + ] Added CommunityNewsFeed [ + ] Added CommunityRankingTable [ + ] Added CommunityThemePack
[ # ] AvatarFrame is now set to work with the default JSON class [ + ] Added AdditionalItemInfo [ + ] Added AvatarFrameConfig [ + ] Added ItemOwnershipInfo [ + ] Added ItemRestrictionInfo [ + ] Added AdditionalItemBenefits
[ # ] Renamed CommunityProfile to GenericProfile as it contains lots of repetetive data not community related [ - ] Deleted BlockedUser as it is just GenericUser [ # ] Adapted Blog to work with the default JSON class [ + ] Added GenericAvatarFrame
[ # ] Chat is now adapted to work with the default JSON class [ + ] Added ChatExtensions [ + ] Added GenericChatMember [ + ] Added LastChatMessageSummary
[ # ] Prepared EventHandler to discontinue Newtonsoft.Json [ + ] Added SocketBase [ # ] Adapted ChatAnnouncement
…edMessage, EventLog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored all objects and classes using them, it will now use the built in system JSON class to handle creating objects faster and more memory efficient than before
Also deleted BlockedUser, FromId and CommunityProfile as they could be replaced with generic objects or already existed in form of other objects